dsa-ou / algoesup

Algorithmic essays support: examples, templates, guides, library
https://dsa-ou.github.io/algoesup/
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Transition from local `allowed` script to PyPi installation #5

Closed densnow closed 4 months ago

densnow commented 4 months ago

Since allowed is now on the PyPi, it might be best to transition away from the local allowed.py script? The benefits include:

For Deepnote we would need to update the Dockerfile and for Datalore we would need to update both init.sh and environment.yml. Furthermore, algoesup.py would need to be updated the most obvious part is checkers dictionary but there could be more.

There might be other changes required here, but I think I have covered the main ones.

mwermelinger commented 4 months ago

Good points. If you could test on DeepNote the PyPI version that would be good. (The current PyPI version can't handle folders, but that shouldn't be a problem in the context of DeepNote.)

mwermelinger commented 4 months ago

We still keep the two JSON files because:

We could delete both files and add # allowed to the imports to omit messages, but we'd need to update the docs and make them robust to future changes in the configuration on PyPI.