search

dsa28s / compose-video

Video UI Component for Jetpack Compose (Powered by androidx.media3)
https://dsa28s.github.io/compose-video/
Apache License 2.0
241 stars 30 forks source link

fix issue #20 and fix full screen padding #26

Closed AnandJeyapal closed 3 months ago

AnandJeyapal commented 4 months ago

This is for the following issue

https://github.com/dsa28s/compose-video/issues/20

What was the issue?

Dialog window has extra padding around it. Hence if there is any content around the video player (top/bottom/right/left), VideoPlayerFullScreenDialog shows the content behind it.

What is the fix?

We should update the layout properties of the dialog window so that it full occupies the screen's size.

I have copied the attributes from activityWindow and applied them to the dialogWindow.

Read more at: https://www.droidcon.com/2024/01/15/camouflage-the-status-bar-with-edge-to-edge-jetpack-compose-screens-and-dialogs/

Less-dev commented 4 months ago

cool bro

dsa28s commented 3 months ago

This PR will release version 1.3.0