search

dsafa / audio-band

Display and control songs from the Windows taskbar
MIT License
658 stars 48 forks source link

Text speed number has weird behaviour (0.9.0 - pre1) #160

Open ingdanko opened 5 years ago

ingdanko commented 5 years ago

The scroll speed text option takes a number, but I couldn't figure out what the number means. Putting in 10 or 100 makes the text go incredibly fast. 10000 made it scroll much more reasonably, but I couldn't figure out what the number means. Also, shouldn't a lower number correspond to a slower scroll?

dsafa commented 5 years ago

I changed it to the number to milliseconds from going from one edge to the other

pascal0312 commented 5 years ago

I have an addition to the scroll issue. Maybe change the scroll speed after clicking 'apply' instead of live. Default is 50ms in pre2 (That's way too fast as a default value) changed it to 1000ms, still too fast and when I deleted the value to go with '5000' the whole explorer crashes because I either have 0 or 'undefined' or '5'is too fast for it to handle.

Suggestions: default speed to 5000 seems alright for me. Don't do live changes, but after user presses apply or set minimum value (>10?)

dsafa commented 5 years ago

The default should be 5000 now. Old settings were kept the same and those had default of 50. I think live changes are useful. A throttle could be applied though, so that it only changes after not typing for a second or so.