search

dsaff / truth-old

Truth: we've made Failure a Strategy
Apache License 2.0
5 stars 2 forks source link

First attempt at generification of CollectionSubject so we can have ListSubject et al. #23

Closed hagbard closed 13 years ago

hagbard commented 13 years ago

This is a bit of a pain as there are now 3 type params (instead of 1) and there's a slightly suspicious looking @SuppressWarnings going on. Other than that, it seems good though.

I've added one extra method in ListSubject (containsSequence) that seems to work but I still need to add more tests cases for error etc...

hagbard commented 13 years ago

So, what's our line length restriction? Some of the generics stuff has gone a bit crazy :)

dsaff commented 13 years ago

I don't know if I'm blinded by tears of joy, or if my eyes are bleeding. Sigh. This is probably the right thing to do, though.

dsaff commented 13 years ago

In terms of line length, github starts wrapping lines at 120 chars, so that should probably be the maximum maximum. Maybe we shoot for 100 where possible?

dsaff commented 13 years ago

Christian, I'm going to merge, to keep agile. If you think we should rollback, let me know.