search

dsaff / truth-old

Truth: we've made Failure a Strategy
Apache License 2.0
5 stars 2 forks source link

Added missing list subject and tests #24

Closed hagbard closed 13 years ago

hagbard commented 13 years ago

Sorry this took so long.

cgruber commented 13 years ago

+1

hagbard commented 13 years ago

Basically I added some JavaDoc and made some changes to the error strings. I think this should be enough to get this in and then I think I'll sit down and have a thunk about stuff.

For example: ASSERT.that(list).isOrdered(); ASSERT.that(list).isPartiallyOrdered(); vs ASSERT.that(list).isOrdered().and().hasUniqueElements(); ASSERT.that(list).isOrdered();

Or: ASSERT.that(collection).forAllElements(somePredicate); ASSERT.that(collection).forSomeElement(somePredicate);

And so on. I'd like to start a shared doc to just bash out some of these ideas (man, this was Wave's ideal use case).

dsaff commented 13 years ago

There's nothing preventing a merge, if both of you are happy with it--there are future tasks we can tackle now or later, but I'm fine with either answer. Let me know if I should merge.

cgruber commented 13 years ago

I'd prefer a merge now, then I'll push those changes to truth0/truth and have people delete their forks and re-fork from truth0/truth, and move things onto that.

In your case, dsaff, I'd say rename your repo to truth-old or some such so you can go back and crib issues and in case we forget something.

cgruber commented 13 years ago

Ping?

hagbard commented 13 years ago

Merging is fine by me unless there was something specific that we needed in my post (I will do more in the next branch or two, just not in this change).

cgruber commented 13 years ago

dsaff... ping? CAn you pull this in so we can move over?