dsaidgovsg / terraform-modules

Reusable Terraform modules

Apache License 2.0

79 stars 23 forks source link

chore(prometheus): unsafe deserialisation #300

Closed Tingweiftw closed 2 days ago

Tingweiftw commented 6 days ago

Story

https://www.notion.so/aipf-locus/Unsafe-Deserialization-1134e47c1d87808792d1eaaff7471966?pvs=4

What Changed

Changed prometheus from a submodule to a directory since it is being archived already (https://github.com/cloudalchemy/ansible-prometheus/tree/2201713a60fa4b215c6b15b76c891e32d454d6e2)
Use yaml.safe_load instead of yaml.load so that the deserialisation is safe.

Tingweiftw commented 2 days ago

For the remaining reference, there is no need to remove as they are independent from the prometheus module (can see that no outputs from prometheus module is reference in the other modules) the remaining reference are variables for users to link up their prometheus client based on the address / port / nomad consul names which are not reliant on the module, so I would rather not remove them