search

dsaltares / fetch-gh-release-asset

Github Action to download an asset from a Github release
MIT License
113 stars 70 forks source link

Don't send token header when token is not set #24

Closed sU8U7SfkcwTJVH7PjaVmej7D closed 3 years ago

sU8U7SfkcwTJVH7PjaVmej7D commented 3 years ago

Seems like github changed its policy: now, sending an empty token header results in a 403 error. This commit fixes my CI.

dsaltares commented 3 years ago

@sU8U7SfkcwTJVH7PjaVmej7D (interesting handle) looks like the tests failed.

sU8U7SfkcwTJVH7PjaVmej7D commented 3 years ago

@dsaltares: INPUT_REPO=dsaltares/godot-wild-jam-18 INPUT_VERSION=tags/v0.1.18 INPUT_FILE=plague-linux.zip GITHUB_REPOSITORY=xxx INPUT_TOKEN= ./fetch_github_asset.sh works fine for me INPUT_REPO=dsaltares/godot-wild-jam-18 INPUT_VERSION=tags/v0.1.18 INPUT_FILE=plague-linux.zip GITHUB_REPOSITORY=xxx INPUT_TOKEN=xxx ./fetch_github_asset.sh fails in the same way the CI test fails.

I guess the "***" in the CLI logs is a hidden token. Could you confirm the CI token used here is valid?

EDIT: I found an issue in the first call to curl and pushed an update. Could you run the CI tests again?