search

dsanel / mongoose-delete

Mongoose Soft Delete Plugin
MIT License
346 stars 101 forks source link

set deleted to false instead of unsetting when calling restore() #150

Open vkarpov15 opened 9 months ago

vkarpov15 commented 9 months ago

Fix Automattic/mongoose#14338

It looks like this commit: https://github.com/dsanel/mongoose-delete/commit/b8c3cea2321dcd583c78c254d1490b3f72c0c14f made it so that the restore() static would unset deleted versus setting it to false, which is backwards breaking for projects that use use$neOperator: false.

mareksuscak commented 2 months ago

I put up another PR that does this before seeing yours. Apologies. Here's mine: https://github.com/dsanel/mongoose-delete/pull/157

vkarpov15 commented 2 months ago

@dsanel would you be open to transferring this project to the mongoosejs GitHub org and handing maintenance over to the Mongoose team? No pressure, this is your project if you want to keep maintaining it, I wanted to ask just in case.