search

dsanson / termpdf.py

A graphical pdf and epub reader that works inside the kitty terminal
MIT License
496 stars 30 forks source link

[RFC] Fix bad rendering on refresh #11

Closed camspiers closed 4 years ago

camspiers commented 4 years ago

In #10 I identified some rendering issues on refresh. This is a first pass at fixing it. It's a bit clumsy, I literally recreate the Document and replace it, and I think that I might be dropping some CLI options in the process, but it does at least fix the underlying issue, and now refreshing no longer has the rendering issues.

camspiers commented 4 years ago

Friendly ping :) @dsanson

dsanson commented 4 years ago

Thanks for this @camspiers! I probably won't have a chance to look at it for at least a week or two, as I am in the midst of winding down teaching my classes.