search

dsanson / termpdf.py

A graphical pdf and epub reader that works inside the kitty terminal
MIT License
506 stars 32 forks source link

termpdf can't detect non supported terminals.... #46

Open Vaisakhkm2625 opened 9 months ago

Vaisakhkm2625 commented 9 months ago

I have been reading through code and find this

def detect_support():
    return write_gr_cmd_with_response(dict(a='q', s=1, v=1, i=1), standard_b64encode(b'abcd'))

For terminals that doesn't support kitty protocol won't give a response... so this function will hangs... is it ok to wait for a fixed time for response and if there is no response resume the control flow?? i think this is the same issue this pull request https://github.com/dsanson/termpdf.py/pull/44 trying to fix....