Project Feedback!

[codepathreview]

@dsatija : could you pls check if you have pushed the latest code? I cant find the MovieDetailActivity in current codebase. If it is already there, can you pls point me to it. Pls update status here.

Thanks

[dsatija]

Hi, Apologies.I have uploaded the file under Intents folder now. Thanks.

[codepathreview]

:+1: Good work getting all required and few optional stories done. A few notes after checking out the code:

• Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
• Good job on a decent UI
• Great work implementing tabbed layout
• Nice to see you used the SwipeRefreshLayout for easy stream refreshes
• Consider better organizing your source files. The hierarchy seems a bit messed up.
• Good job using the ViewHolder pattern to improve performance of photos in ListView.
• Consider including a check to see if internet is available to detect any network failures. Show an appropriate message in case of failure.
• Consider refactoring code all over the app into smaller methods which do one thing specifically. Eg. In onCreate of activities, you have done UI initialization, setting up listeners and calling fetch method all in one place. A cleaner way would be to move UI init to its own method and setting up listener to its own. Similarly the adapter needs refactoring.

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@codepath.com.

P.S. Good to see you properly added the README with features and GIF to your project as described in the submitting assignments guide!