Project Feedback

[codepathreview]

:+1: nice work. A few notes after checking out the code:

• Good work on a clean UI, and adding the buttons for reply, retweet, favorite
• Good to see you were able to format the timestamp cleanly
• Good to see you refreshed the timeline after composing a new tweet
• Nice touch with the character count being displayed while the user composes a tweet
• Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
• Good to see you added DBFlow annotations to the models
• Good job adding offline support
• The README marked few features as complete - detailed view, and clicking on link within body - but neither could I verify these in the GIF, nor find them in the codebase.
• You have duplicated the code to make API call and update list/adapter. This should be refactored.
• Consider using Butterknife for View injection.
• Consider using the ViewHolder pattern to improve performance of ListView.
• Consider adding [progress bars] (http://guides.codepath.com/android/Handling-ProgressBars#actionbar-progress-bar) to your app whenever a network request goes out

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

[dsatija]

Hi ,Thanks for the feedback. I checked the detailed tweet activity requirement by mistake.Apologies for that.thanks!

[codepathreview]

:+1: nice work. A few notes after checking out the code:

• Good to see you used ViewPager and TabLayout. These components are recommended by Material Design to enhance user experience and are found in majority of the apps. ViewPager can also be used separately without TabLayout to show paging of content using swipe in any section of the screen layout.
• Nice to see you used a drawable and styles to customize the app. Get more familiar with creating custom drawables and styles by trying to customize different widgets.
• In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide.
• Nice to see you played around with styling the sliding tab strip.
• Nice to see you appropriately used OnClickListeners on the user's profile image to navigate to their profile view.
• Nice to see you properly communicated the user to the user timeline fragment from the profile activity.
• Glad to see you properly hooked up each of the different timelines to infinitely paginate.
• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!
• Consider using RecyclerView over ListView. RecyclerView is an advanced and a more performant version of ListView and its use is considered best practice.
• Try out the third-party ButterKnife library to simplify a lot of boilerplate findViewById() calls.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

[dsatija]

Hi, I have added an indeterminate progress indicator in the timelines ...is it the same you have asked for in the feedback..or am i missing something else?

[codepathreview]

@dsatija Apologies. That was an oversight. That point has been removed.