dsavell / docker-grav

Docker Container for GRAV CMS
MIT License
40 stars 18 forks source link

SMTP emailing issues #1

Closed esapy closed 5 years ago

esapy commented 5 years ago

Dear David,

I discovered an issue related to the grav-admin module. The forgot password functionality (or any email notification) was not sending emails. The exception traceback routed the problem in the EHLO and HELO SMTP protocol commands resulting in a 501 (invalid domain address).

The nginx configuration /etc/nginx/conf.d/default.conf has a setting,

server_name _;

This should be changed to,

server_name $hostname;

After restarting the container, the email notifications began working as advertised.

I have a temporary solution in post-processing (which could be included in the Dockerfile):

sed -i 's/server_name.*/server_name $hostname;/' /etc/nginx/conf.d/default.conf

Thanks for the awesome docker. It's one of the few that's using the most recent version(s) (php + grav).

Cheers,

Hans

dsavell commented 5 years ago

Hey Hans,

Cheers for the update, funny that I received this email just in time, I am making changes to the image currently I will try to include this also.

Regards,

On Mon, 10 Jun 2019 at 19:41, esapy notifications@github.com wrote:

Dear David,

I discovered an issue related to the grav-admin module. The forgot password functionality (or any email notification) was not sending emails. The exception traceback routed the problem in the EHLO and HELO SMTP protocol commands resulting in a 501 (invalid domain address).

The nginx configuration /etc/nginx/conf.d/default.conf has a setting,

servername ;

This should be changed to,

server_name $hostname;

After restarting the container, the email notifications began working as advertised.

I have a temporary solution in post-processing (which could be included in the Dockerfile):

sed -i 's/server_name.*/server_name $hostname;/' /etc/nginx/conf.d/default.conf

Thanks for the awesome docker. It's one of the few that's using the most recent version(s) (php + grav).

Cheers,

Hans

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dsavell/docker-grav/issues/1?email_source=notifications&email_token=ADTHYKBR6K7YNUUQDQTDGD3PZ2N53A5CNFSM4HWWG6H2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GYUH3EQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ADTHYKG52GHZ6IZY3MAVSLTPZ2N53ANCNFSM4HWWG6HQ .

esapy commented 5 years ago

Thanks!

dsavell commented 5 years ago

Fixed in latest release "The Refactor Release" thanks for contributing!