Closed hughbris closed 2 years ago
Heya, if your able to rebase this code, I can get it merged for the next release.
Thanks David, do you have a timeframe in mind?
Can probably look at it tomorrow rebuild the same version if you need it?
On Fri, 20 May 2022 at 01:26, Hugh Barnes @.***> wrote:
Thanks David, do you have a timeframe in mind?
— Reply to this email directly, view it on GitHub https://github.com/dsavell/docker-grav/pull/37#issuecomment-1132322895, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTHYKGW6G4UCBI2SJDXSFTVK3L5FANCNFSM5PAEFAJA . You are receiving this because you commented.Message ID: @.***>
Sorry you are probably asking a straightforward question, but it's too much to get my head around now. I will see if I can rebase by tomorrow (actually tomorrow is Saturday here, you probably mean today!). If not, flag it if it's too tricky. We'll get the next release. No people banging at the door, I'm pretty sure :D
Wait we’re not all UTC? ;) haha no problem will keep an eye on the PR over the next few days I will wait :)
On Fri, 20 May 2022 at 01:35, Hugh Barnes @.***> wrote:
Sorry you are probably asking a straightforward question, but it's too much to get my head around now. I will see if I can rebase by tomorrow (actually tomorrow is Saturday here, you probably mean today!). If not, flag it if it's too tricky. We'll get the next release. No people banging at the door, I'm pretty sure :D
— Reply to this email directly, view it on GitHub https://github.com/dsavell/docker-grav/pull/37#issuecomment-1132326892, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTHYKG4J6IRHTEIGZSGWILVK3M4FANCNFSM5PAEFAJA . You are receiving this because you commented.Message ID: @.***>
Hmm, a blank line. Spurious conflict! :)
Merged & Built
This is pretty much straight out of my own Caddy-based grav image. I still use your nginx image for at least one multisite because the multisite setup does not seem to work under Caddy.
I find it an invaluable option for staging environments so that they won't be indexed. (I have now given up trying to protect staging environments with HTTP auth and explaining that to clients!).
Of course, the
/robots.txt
file sits above Grav'suser
folder and is out of reach of the standard bind mounts.Other ways this could be achieved:
So, while not essential, this seems simplest, and I make use of it plenty.