dsavransky / EXOSIMS

Simulator for exoplanet direct imaging space missions
BSD 3-Clause "New" or "Revised" License
27 stars 40 forks source link

luminousity units seem inconsistent #248

Closed douglase closed 1 year ago

douglase commented 4 years ago

Describe the bug StarCatalog.py L44 , and L105 and KnownRVPlanetList define luminousity as ln(L_sol) but it is treated as being in units of L_sun, converted from log10(L_sun) (which is the unit used by IPAC), e.g. https://github.com/dsavransky/EXOSIMS/blob/0c46945ae0b915f97157fb17de3eb344f5945e74/EXOSIMS/TargetList/KnownRVPlanetsTargetList.py#L83

To Reproduce print(sim.TargetList.L) for 51 Eri returns 7.07945784e+00 which is the Luminosity in L_sun, no log.

Expected behavior I think the documentation should be probably changed to match the current behavior, but am not sure if L is used elsewhere as a ln, so wanted to report as an issue rather than a PR.

EXOSIMS version: