search

dsavransky / EXOSIMS

Simulator for exoplanet direct imaging space missions
BSD 3-Clause "New" or "Revised" License
26 stars 40 forks source link

fZQuads must be updated to handle multiple instruments #289

Closed deanthedream closed 1 year ago

deanthedream commented 2 years ago

https://github.com/dsavransky/EXOSIMS/blob/48ed9cddb41b1dff14503052671d296dc2ded1be/EXOSIMS/Prototypes/ZodiacalLight.py#L364

deanthedream commented 2 years ago

Basically the small section of code before this and this section of code need to be updated to handle multiple instruments in the spec file. Nobody used 2 instruments when this was first created. Basically if fZQuads is calculated based on the keepout map of a coronagraph (which has smaller KO regions), then time will be advanced based on "Izod:fZmin" policies to the local zodiacal light within the substantially larger KO window of the starshade instrument. fZQuads needs to be iterated over and computed separately for multiple different instruments. It is also important to take the integration time into account when advancing time (you need to advance to a time before the target star exits keepout. this is accounted for in the coronagraph only scenarios of SLSQP, there is some small potential it isnt since I only needed to advance to fZmin).

dsavransky commented 1 year ago

Implemented in v3.0.0.