search

dsavransky / EXOSIMS

Simulator for exoplanet direct imaging space missions
BSD 3-Clause "New" or "Revised" License
26 stars 40 forks source link

fz_startSaved Needs to be computed as an input for calcfZmin #294

Closed deanthedream closed 1 year ago

deanthedream commented 2 years ago

https://github.com/dsavransky/EXOSIMS/blob/7a22a8a2d084490b05987839431e00e2a0483ae7/EXOSIMS/ZodiacalLight/Stark.py#L261

The problem here is that SS.init generates fZ_startSaved using the first detection mode. When tiered scheduler_DD calls calcfZmin for the occulter, it needs to use a newly created fZ_startSaved calculation and not the one for the detection mode. This specific line needs to become an input to the function as either the array or None. If None, call self.generatefZ, if precomputed, use that instead. In Tiered Scheduler, the calcfZmin needs to have occ_fZ_startSaved passed in. This means ZL.generateFZ needs to be called on the preceding line.

dsavransky commented 1 year ago

@ggenszler I think this will be covered by your previous and current set of changes to fZ calculations. Please tag the error on next commit to cover it, or close the issue if it is already covered.

dsavransky commented 1 year ago

Closed by #327