dsavransky / EXOSIMS

Simulator for exoplanet direct imaging space missions
BSD 3-Clause "New" or "Revised" License
26 stars 40 forks source link

Need to switch to apply_space_motion() for handling proper motions #313

Open dsavransky opened 1 year ago

dsavransky commented 1 year ago

Is your feature request related to a problem? Please describe. EXOSIMS originally implemented its own proper motion code (in TargetList.starprop) but this is no longer needed as astropy coordinates are fully capable of tracking space motions on their own.

Describe the solution you'd like TargetList.starprop needs to be switched to calls to apply_space_motion(). See: https://docs.astropy.org/en/stable/coordinates/apply_space_motion.html

This will require packaging proper motion values in with the sky coordinates, which needs to happen inside of all current StarCatalog implementations. In TargetList, pmra and pmdec attributes will need to be deprecated and nanfilter updated accordingly.