dsavransky / EXOSIMS

Simulator for exoplanet direct imaging space missions
BSD 3-Clause "New" or "Revised" License
25 stars 35 forks source link

Fix DulzPlavchan mass generation #322

Open CoreySpohn opened 1 year ago

CoreySpohn commented 1 year ago

Describe the bug The implementation of DulzPlavchan can generate massive planets (sometimes solar mass) because it tries to invert Forecaster and doesn't use the PlanetPhysicalModel.

To Reproduce Steps to reproduce the behavior: Generate masses with DulzPlavchanUniverse or DulzPlavchanUniverseEarthsOnly

Expected behavior It should either invert through probabilistic sampling of the masses based on generated radii or generate the masses and then sample Forecaster for radius.

EXOSIMS version: