issues
search
dsavransky
/
EXOSIMS
Simulator for exoplanet direct imaging space missions
BSD 3-Clause "New" or "Revised" License
26
stars
40
forks
source link
fZ update
#327
Closed
ggenszler
closed
1 year ago
ggenszler
commented
1 year ago
Describe your changes
Removed fZQuads and redundant fZ calculation code.
Moved all intTimeFilterInds-related calculations to the SurveySimulation Prototype.
Fixed intTimeFilterInds definition, previously set to the filtering inds of the last mode out of allModes.
Type of change
Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update
Reference any relevant issues (don't forget the #)
297 - verified m is defined in this scope
295 - unsure if line is ever called, but the comparison can be made
294 - an equivalent to fz_startSaved is calculated and is used in calcfZmin
292 - fZmins is now calculated and the hashname includes the mode hex
Checklist before requesting a review
[x] I have verified that all unit tests pass in a clean virtual environment and added new unit tests, as needed
[x] I have run
e2eTests
and added new test scripts, as needed
[x] I have verified that all docstrings are properly formatted and added new documentation, as needed
Describe your changes
Type of change
Reference any relevant issues (don't forget the #)
297 - verified m is defined in this scope
295 - unsure if line is ever called, but the comparison can be made
294 - an equivalent to fz_startSaved is calculated and is used in calcfZmin
292 - fZmins is now calculated and the hashname includes the mode hex
Checklist before requesting a review
e2eTests
and added new test scripts, as needed