Previously, some elements of the input specification could use environment variables in paths, but not others. All relevant places in the code have been updated so that environment variables can be used in any path input.
Multiple schedulers had potential failure points where an integration time (quantity) is added to a Time object. If any element of the integration time array is NaN this throws an error. All relevant locations have been patched to avoid such errors.
process_opticalsys_package output filenames updated to avoid extra underscores in some cases. Output dictionary now also includes explicit input_angle_units entry.
calc_dMag_per_intTime in Nemati opticalsystem has been updated to handle various input edge cases, including zero/nan integration times and out of bounds working angles.
The fZ cache files were previously named such that differently-sized target lists could (in rare instances) generate the same filename. This has been fixed by explicitly including the targetlist size in the filename.
Multiple instances of redundant fZ calculation/loading have been removed in both the prototype and multiple scheduler implementations.
Fixed all instances of 'if char_intTime` as asserting the truth of a quantity is deprecated.
The following features were added:
Divide & multiply bad value warnings in Nemati opticalsystem are now suppressed by default.
process_opticalsys_package now has a to_arcsec keyword (default False) that forces conversion of input angle value to arcseconds.
Added new utility methods min_deltaMag_Lambert and max_deltaMag_Lambert to util.deltaMag.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist before requesting a review
[ ] I have verified that all unit tests pass in a clean virtual environment and added new unit tests, as needed
[ ] I have run e2eTests and added new test scripts, as needed
[ ] I have verified that all docstrings are properly formatted and added new documentation, as needed
Describe your changes
The following bugs were addressed:
process_opticalsys_packageoutput filenames updated to avoid extra underscores in some cases. Output dictionary now also includes explicitinput_angle_unitsentry.calc_dMag_per_intTimein Nemati opticalsystem has been updated to handle various input edge cases, including zero/nan integration times and out of bounds working angles.fZcache files were previously named such that differently-sized target lists could (in rare instances) generate the same filename. This has been fixed by explicitly including the targetlist size in the filename.The following features were added:
process_opticalsys_packagenow has ato_arcseckeyword (default False) that forces conversion of input angle value to arcseconds.min_deltaMag_Lambertandmax_deltaMag_Lamberttoutil.deltaMag.Type of change
Checklist before requesting a review
e2eTestsand added new test scripts, as needed