Turned the commonSystemInclination system into a commonSystemPlane system, where the TargetList generates both a systemInclination and systemOmega then offsets the planets based on commonSystemPlaneParams. Changed the TL attribute "I" to "systemInclination" to avoid confusion with the SimulatedUniverse "I" attribute for the planet inclinations. Small performance improvement by moving the "converged" Boolean in Nemati's calc_dMag_per_intTime function out of the lower bound loop to avoid always running the minimization twice.
Type of change
Bug fix (non-breaking change which fixes an issue)
Checklist before requesting a review
[ x ] I have verified that all unit tests pass in a clean virtual environment and added new unit tests, as needed
[ x ] I have run e2eTests and added new test scripts, as needed
[ x ] I have verified that all docstrings are properly formatted and added new documentation, as needed
Describe your changes
Turned the commonSystemInclination system into a commonSystemPlane system, where the TargetList generates both a systemInclination and systemOmega then offsets the planets based on commonSystemPlaneParams. Changed the TL attribute "I" to "systemInclination" to avoid confusion with the SimulatedUniverse "I" attribute for the planet inclinations. Small performance improvement by moving the "converged" Boolean in Nemati's calc_dMag_per_intTime function out of the lower bound loop to avoid always running the minimization twice.
Type of change
Checklist before requesting a review
e2eTestsand added new test scripts, as needed