search

dsc / bunch

A Bunch is a Python dictionary that provides attribute-style access (a la JavaScript objects).
http://github.com/dsc/bunch
MIT License
482 stars 177 forks source link

Python 3 testing should be not #55

Closed ishahak closed 1 month ago

ishahak commented 1 year ago

I'm suspecting that the coverage for python 2 (which I use as CircuitPython) is broken. the 'if' and 'else' should be swapped:

https://github.com/dsc/bunch/blob/34eedf58fae929b3bb017338d24e978156dafa2b/bunch/python3_compat.py#L16

because in Python 2, you can't say iteritems = dict.iteritems iterkeys = dict.iterkeys

as dict doesn't include them

dsc commented 1 month ago

Yep. This has been fixed.