search

dscalzi / HeliosLauncher

☀ Custom launcher for modded minecraft written in Electron and Node.js
MIT License
853 stars 1.76k forks source link

ECONNRESET Error on Minecraft assets domain #268

Closed damsdev1 closed 1 year ago

damsdev1 commented 1 year ago

Hello,

There is a small problem when I download Minecraft assets in 1.19.3 (not tested previous versions).

There is an ECONNRESET that occurs (I'm not the only one, it does it to some friends too). I've noticed that this error occurs on sounds most of the time. (https://resources.download.minecraft.net/aa/aa1d3aace1c481ac32d5827fba287294b6bc99fb https://resources.download.minecraft.net/b8/b83bbafa9799680da24f10215de2c40b73ce1fe3)

After reloading the application, this problem disappears for the first sound download (ECONNRESET error), and appears for the second sound download (ECONNRESET error). Reloading the application again makes the problem disappear.

Is there a solution or an explanation for this problem?

Thanks.

dscalzi commented 1 year ago

rewriting assetguard, let's see if that fixes anything..

https://github.com/dscalzi/HeliosLauncher/pull/270

dscalzi commented 1 year ago

@DamsDev1 #270 is testable if you want to give it a whirl

dscalzi commented 1 year ago

I have confirmed that #270 fixes this issue via retries. The minecraft endpoint is unstable and if one connection fails we will simply retry it up to 10 times. The maximum retries I've seen it take are 4, so the liklihood of this interrupting the download process with 10 retries is extremely low.