search

dscalzi / HeliosLauncher

☀ Custom launcher for modded minecraft written in Electron and Node.js
MIT License
830 stars 1.72k forks source link

[Windows] Illegal folder names in modstore stops the launcher root directory from being deleted. #338

Open Tjmaxmillion opened 6 months ago

Tjmaxmillion commented 6 months ago

The mod Create: Interactive has a folder called aux located at "org\valkyrienskies\create_interactive\aux" in the JAR.

When this mod is moved to the modstore the aux folder ends up there meaning the root directory of the launcher can't be deleted until the aux folder is deleted with the command line.

For a normal user it's unlikely for them to find the aux folder and know this is what is preventing them from deleting the root directory of the launcher. Further I doubt a normal user would know how to use the command line to delete this folder.

Implement something to help with edge cases where Illegal folder/files names are used in jar files?

Image Source image

dscalzi commented 6 months ago

Doesnt this sound like a defect with the mod, and not the launcher?

Tjmaxmillion commented 6 months ago

I don't think the mods creators intended the mods files to be stored outside the JAR file by a user, none the less I did make a issue for the mod too.

But this issue is exclusive to helious because it doesn't store mods in JAR files like other launchers.

dscalzi commented 6 months ago

The launcher does not extract any files from mod jars?

GeekCornerGH commented 6 months ago

@Tjmaxmillion can I take a look at your distribution file?