search

dscalzi / HeliosLauncher

☀ Custom launcher for modded minecraft written in Electron and Node.js
MIT License
830 stars 1.72k forks source link

Add an option to change true language files #339

Open Shisuiicaro opened 5 months ago

Shisuiicaro commented 5 months ago

Add a selection menu in settings, to change the language of the launcher

Sandro642 commented 4 months ago

Do you want a dropdown menu in the settings to choose the launcher's language?

Sandro642 commented 4 months ago

I am going to develop this, and later there will be a pull request for that. Keep up with the latest news announced on the Aventium Softworks Discord server.

Shisuiicaro commented 4 months ago

Ok, thanks!

Ulysse2211 commented 3 months ago

@Shisuiicaro, because this is taking a long time, I'm gonna try to make it too, so I might do a pr today or this weekend.

Shisuiicaro commented 3 months ago

Thanks, i aprecciate that

dscalzi commented 3 months ago

I18n is not in scope here

GeekCornerGH commented 3 months ago

@Ulysse2211 ^

Ulysse2211 commented 3 months ago

I18n is not in scope here

Don't worry, in that case, i'll send him the modified part so he can add it in his own launcher.

IkyMax commented 3 months ago

@Shisuiicaro, because this is taking a long time, I'm gonna try to make it too, so I might do a pr today or this weekend.

@Sandro642 actually did most of the work for the language selector, it has some errors with cache and applying the languague but it kind of works

@Ulysse2211

Ulysse2211 commented 3 months ago

actually did most of the work for the language selector, it has some errors with cache and applying the languague but it kind of works

Same here, the language selector is all done but there is some errors.

Shisuiicaro commented 3 months ago

can someone send me the repo?

Ulysse2211 commented 3 months ago

@Shisuiicaro, I just finished it, you can find the modifications here: https://github.com/Ulysse2211/Helios-pr/tree/change-language-in-settings

Ulysse2211 commented 3 months ago

If you have any questions, feel free to hit me up on discord (.ulysse2211.)