search

dscalzi / helios-core

♾️ A library containing core mechanisms for Helios Launcher
GNU Lesser General Public License v3.0
13 stars 19 forks source link

Fix mojang status #1

Closed lucas-luchack closed 2 years ago

lucas-luchack commented 2 years ago

Proposal for a fix

dscalzi commented 2 years ago

@lucas-luchack can you allow pushes on the PR pls

lucas-luchack commented 2 years ago

@lucas-luchack can you allow pushes on the PR pls

I can't see the checkbox to change that, idk why...

lucas-luchack commented 2 years ago

GitHub Screenshot

dscalzi commented 2 years ago

try in a web browser maybe https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

lucas-luchack commented 2 years ago

Okay, I fix the problem

It was because the fork was on an organization and not my personal account. Now it works. Sorry again for the wait...

dscalzi commented 2 years ago

Works for me, the status check system is not ideal but I'm not too worried about it right now.