dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
341 stars 141 forks source link

ADGroup: Changing group membership management mechanism #621

Closed jeremyciak closed 4 years ago

jeremyciak commented 4 years ago

Pull Request (PR) description

This Pull Request is intended to change the way that the ADGroup resource manages group membership. The new implementation abandons usage of Add-ADGroupMember and Remove-ADGroupMember due to limitations with Foreign Security Principals. Instead we opt to utilize Set-ADGroup with the Add and Remove parameters, passing a hash object with the member key and a list of formatted SID values (e.g. - "<SID=SID_VALUE>").


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #621 into master will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #621    +/-   ##
======================================
  Coverage      98%    98%            
======================================
  Files          24     24            
  Lines        3110   3208    +98     
======================================
+ Hits         3049   3149   +100     
+ Misses         61     59     -2