dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
345 stars 142 forks source link

ADOrganizationalUnit : Removing Credential from the list of desired values to compare #623

Closed jmos5156 closed 4 years ago

jmos5156 commented 4 years ago

Pull Request (PR) description

Removing Credential from the list of desired values to compare if passed. It currently conflicts with the values passed from the Get-TargetResource function, when credential is passed.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #623 into master will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #623    +/-   ##
======================================
  Coverage      98%    98%            
======================================
  Files          24     25     +1     
  Lines        3110   3335   +225     
======================================
+ Hits         3049   3275   +226     
+ Misses         61     60     -1     
X-Guardian commented 4 years ago

Hi @jmos5156, can you raise an issue with details of the problem you are seeing for this. Cheers.

X-Guardian commented 4 years ago

@jmos5156, are you able to make the requested changes to this PR?

jmos5156 commented 4 years ago

Yes. Will fire up the laptop and submit

On Thu, 13 Aug 2020, 20:28 Simon Heather, notifications@github.com wrote:

@jmos5156 https://github.com/jmos5156, are you able to make the requested changes to this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dsccommunity/ActiveDirectoryDsc/pull/623#issuecomment-673667603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIHBH2RFLNFPXN5RVBWFWHLSAQ5EVANCNFSM4PW5HJZQ .

stale[bot] commented 4 years ago

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.