dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
345 stars 142 forks source link

ADUser: add SamAccountName parameter #660

Open gaelicWizard opened 3 years ago

gaelicWizard commented 3 years ago

Pull Request (PR) description

Adds optional parameter SamAccountName to ADUser resource to allow setting this property separately. This requires that UserName be specified using something other than the SamAccountName, e.g. SID, DN, UPN, &c.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #660 (48b01e1) into main (9346a1d) will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #660   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3408           
===================================
  Hits       3340   3340           
  Misses       68     68           
gaelicWizard commented 3 years ago

I don't have integration tests in here

stale[bot] commented 3 years ago

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.