dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
344 stars 142 forks source link

ADOrganizationalUnit: add property "RestoreFromRecycleBin" to ignorelist #664

Closed svenboll closed 2 years ago

svenboll commented 3 years ago

Pull Request (PR) description

addtional fix to not check parameter "RestoreFromRecycleBin" if it is in desired state.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #664 (44c5591) into main (8d2d716) will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #664   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3408           
===================================
  Hits       3340   3340           
  Misses       68     68           
Impacted Files Coverage Δ
...DOrganizationalUnit/MSFT_ADOrganizationalUnit.psm1 100% <100%> (ø)
johlju commented 2 years ago

Thanks for this! 🙂 I added a test to this to verify the error and that it has been solved with the proposed change.