dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
341 stars 141 forks source link

ADOrganizationalUnit: Added DomainController Parameter #563 #666

Closed matt2005 closed 2 years ago

matt2005 commented 2 years ago

Pull Request (PR) description

Adds DomainController Parameter

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #666 (1458dd3) into main (1b336ff) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #666   +/-   ##
===================================
  Coverage    97%    98%           
===================================
  Files        25     25           
  Lines      3433   3471   +38     
===================================
+ Hits       3364   3402   +38     
  Misses       69     69           
Impacted Files Coverage Δ
...DOrganizationalUnit/MSFT_ADOrganizationalUnit.psm1 100% <100%> (ø)
matt2005 commented 2 years ago

HQRM appears to be failing due to #669 and will be resolved by #670. Once #670 is merged i will rebase off main and recommit.

johlju commented 2 years ago

I updated the pipeline files from Sampler - so the pipeline works now. Please rebase this PR when you have a chance.

johlju commented 2 years ago

@matt2005 awesome! Thank you for this! 😄