search

dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
335 stars 140 forks source link

PowerShell 7.2+ Errors due to Removal of PSDesiredStateConfiguration #669

Closed matt2005 closed 2 years ago

matt2005 commented 2 years ago

PowerShell 7.2 has removed the PSDesiredStateConfigurationModule. PowerShell 7.2 Removal of DSC Module

Need to Add PSDesiredStateConfiguration to required modules

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity from the community in the last 30 days. It will be closed if no further activity occurs within 10 days. If the issue is labelled with any of the work labels (e.g bug, enhancement, documentation, or tests) then the issue will not auto-close.

stale[bot] commented 2 years ago

This issue has been automatically closed because it is has not had activity from the community in the last 40 days.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity from the community in the last 30 days. It will be closed if no further activity occurs within 10 days. If the issue is labelled with any of the work labels (e.g bug, enhancement, documentation, or tests) then the issue will not auto-close.

johlju commented 2 years ago

The reason for the pipeline did not work was because it wasn't using the latest pipeline files from the project Sampler. I updated the files now and the pipeline works again. HQRM Test are using Windows PowerShell to run.

I think the proposed change in PR #670 that suggests using the v2.0.5 version of PSDesiredStateConfiguration in the example might add a complexity to users still on Windows PowerShell where the built in PSDesiredStateConfiguration can be used. I think we need to take a broader approach if we gonna move this module to PowerShell 7, with proper documentation what works and what does not work.

gaelcolas commented 2 years ago

Yeah, and I see little benefit in moving to psdsc 2.0.5 Making it compatible with 3.0.beta1 directly would probably be best. That does mean converting to class based DSC Resources though.

johlju commented 2 years ago

Closing this for now. Another issue need to be opened to track moving to class-based and PS 7.