dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
341 stars 141 forks source link

ADServicePrincipalName: Call test at the top of set in case of explicit call to set function #707

Closed dan-hughes closed 7 months ago

dan-hughes commented 7 months ago

Pull Request (PR) description

Add check at the top of Set-TargetResource to cover case when Invoke-DscResource -Method Set is called

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98%. Comparing base (fcc8b5d) to head (527d927). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/707/graphs/tree.svg?width=650&height=150&src=pr&token=p3P3tBCItu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/707?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #707 +/- ## =================================== Coverage 98% 98% =================================== Files 25 25 Lines 3471 3475 +4 =================================== + Hits 3402 3406 +4 Misses 69 69 ``` | [Files](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/707?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [...vicePrincipalName/MSFT\_ADServicePrincipalName.psm1](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/707?src=pr&el=tree&filepath=source%2FDSCResources%2FMSFT_ADServicePrincipalName%2FMSFT_ADServicePrincipalName.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9NU0ZUX0FEU2VydmljZVByaW5jaXBhbE5hbWUvTVNGVF9BRFNlcnZpY2VQcmluY2lwYWxOYW1lLnBzbTE=) | `100% <100%> (ø)` | |
johlju commented 7 months ago

Thanks for this! Great work! 🙂