dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
336 stars 140 forks source link

ADReadOnlyDomainControllerAccount: New resource #713

Closed Borgquite closed 1 month ago

Borgquite commented 1 month ago

Pull Request (PR) description

As discussed in #711 - a new resource to allow pre-staging of read-only domain controller accounts

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

Borgquite commented 1 month ago

Just doing an initial pull to see if this works before I update the tests - leave this with me for now :)

johlju commented 1 month ago

For the build to run, update azure-pipelines.yml according to this: https://github.com/gaelcolas/Sampler/issues/477#issuecomment-2246099769

Borgquite commented 1 month ago

@johlju Love it when you pop out for lunch & the solution's waiting when you return! Ta! :)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98%. Comparing base (bdde66f) to head (08e2163). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/713/graphs/tree.svg?width=650&height=150&src=pr&token=p3P3tBCItu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/713?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #713 +/- ## ==================================== Coverage 98% 98% ==================================== Files 25 26 +1 Lines 3475 3720 +245 ==================================== + Hits 3406 3651 +245 Misses 69 69 ``` | [Files](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/713?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [...FT\_ADDomainController/MSFT\_ADDomainController.psm1](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/713?src=pr&el=tree&filepath=source%2FDSCResources%2FMSFT_ADDomainController%2FMSFT_ADDomainController.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9NU0ZUX0FERG9tYWluQ29udHJvbGxlci9NU0ZUX0FERG9tYWluQ29udHJvbGxlci5wc20x) | `100% <100%> (ø)` | | | [...ccount/MSFT\_ADReadOnlyDomainControllerAccount.psm1](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/713?src=pr&el=tree&filepath=source%2FDSCResources%2FMSFT_ADReadOnlyDomainControllerAccount%2FMSFT_ADReadOnlyDomainControllerAccount.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9NU0ZUX0FEUmVhZE9ubHlEb21haW5Db250cm9sbGVyQWNjb3VudC9NU0ZUX0FEUmVhZE9ubHlEb21haW5Db250cm9sbGVyQWNjb3VudC5wc20x) | `100% <100%> (ø)` | | | [...DirectoryDsc.Common/ActiveDirectoryDsc.Common.psm1](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/713?src=pr&el=tree&filepath=source%2FModules%2FActiveDirectoryDsc.Common%2FActiveDirectoryDsc.Common.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL01vZHVsZXMvQWN0aXZlRGlyZWN0b3J5RHNjLkNvbW1vbi9BY3RpdmVEaXJlY3RvcnlEc2MuQ29tbW9uLnBzbTE=) | `95% <100%> (+<1%)` | :arrow_up: |
Borgquite commented 1 month ago

@johlju This PR is ready for review whenever you are :)

Borgquite commented 1 month ago

@johlju Let me know if I haven't explained the above very well!

Borgquite commented 1 month ago

@johlju Ping - when you are able!

Borgquite commented 1 month ago

I've updated Get-DomainControllerObject to make the intended fix clearer