dsccommunity / ActiveDirectoryDsc

This module contains DSC resources for deployment and configuration of Active Directory Domain Services.
MIT License
341 stars 141 forks source link

ADObjectPermissionEntry: Fix escaping issue when getting/setting ACLs #716

Closed Borgquite closed 2 months ago

Borgquite commented 2 months ago

Pull Request (PR) description

Fixes #675 - when using ADObjectPermissionEntry to configure an ACL on a Path that requires escaping (comma, backslash, hash, plus etc), the command fails with 'The object name has bad syntax'

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98%. Comparing base (7c3feec) to head (61fd9e1). Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/716/graphs/tree.svg?width=650&height=150&src=pr&token=p3P3tBCItu&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #716 +/- ## =================================== Coverage 98% 98% =================================== Files 26 26 Lines 3720 3720 =================================== Hits 3651 3651 Misses 69 69 ``` | [Files with missing lines](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/716?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [...tPermissionEntry/MSFT\_ADObjectPermissionEntry.psm1](https://app.codecov.io/gh/dsccommunity/ActiveDirectoryDsc/pull/716?src=pr&el=tree&filepath=source%2FDSCResources%2FMSFT_ADObjectPermissionEntry%2FMSFT_ADObjectPermissionEntry.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9NU0ZUX0FET2JqZWN0UGVybWlzc2lvbkVudHJ5L01TRlRfQURPYmplY3RQZXJtaXNzaW9uRW50cnkucHNtMQ==) | `100% <100%> (ø)` | |