add certreq basic error handling

kilasuit commented 4 years ago

Pull Request (PR) description

Adds simple error handling for certreq call

This Pull Request (PR) fixes the following issues

Fixes #224

Task list

[x] Added an entry under the Unreleased section of the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in the resource folder.
[ ] Resource parameter descriptions added/updated in schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

PlagueHO commented 4 years ago

Thanks @kilasuit - can you add an entry to the CHANGELOG.md in the Unreleased section? Also, a recent breaking change to ModuleBuilder broke all the builds. So I've got to fix #230 before this one can go through. Will submit a PR for that shortly so your build can pass.

PlagueHO commented 4 years ago

@kilasuit - should be able to rebase now as the build pipeline fix PR is through.

johlju commented 4 years ago

@PlagueHO do you have time to review this one now when it passes the tests?

kilasuit commented 4 years ago

Nitpick- can you add a full stop at the end?

So I tried this, a few different times and ways it then broke the test 🤷‍♂️ so I had to remove that last fullstop

dsccommunity / CertificateDsc