This PR primarily removes the testing requirement to use the New-SelfSignedCertificateEx. This resource will no longer be able to be tested on Windows Server 2012 R2 - although the resources will still work. This is to simplify testing and remove dependencies.
I also refactored the code and tests and in the process identified an issue where FIPS support wasn't available on PS Core 6/PS 7. So, this has also been fixed.
Finally, I improved the overall resource performance by adding caching to the thumbprint hashing check code. This increases test performance significantly and speeds up CI from 45 min to 12 min.
This Pull Request (PR) fixes the following issues
Changed
Changed Test-Thumbprint to cache supported hash algorithms to increase
performance - Fixes Issue #221.
Fixed
Removed requirement for tests to use New-SelfSignedCertificateEx from
TechNet Gallery due to retirement.
This will prevent tests from running on Windows Server 2012 R2 - Fixes Issue #250.
Fixed FIPS support when used in versions of PowerShell Core 6 & PowerShell 7.
Moved thumbprint generation for testing into helper function New-CertificateThumbprint
and fixed tests for validating FIPS thumbprints in Test-Thumbprint so that it runs
on PowerShell Core/7.x.
Task list
[x] Added an entry under the Unreleased section of the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in the resource folder.
[ ] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
Pull Request (PR) description
This PR primarily removes the testing requirement to use the
New-SelfSignedCertificateEx. This resource will no longer be able to be tested on Windows Server 2012 R2 - although the resources will still work. This is to simplify testing and remove dependencies.I also refactored the code and tests and in the process identified an issue where FIPS support wasn't available on PS Core 6/PS 7. So, this has also been fixed.
Finally, I improved the overall resource performance by adding caching to the thumbprint hashing check code. This increases test performance significantly and speeds up CI from 45 min to 12 min.
This Pull Request (PR) fixes the following issues
Changed
Test-Thumbprintto cache supported hash algorithms to increase performance - Fixes Issue #221.Fixed
New-SelfSignedCertificateExfrom TechNet Gallery due to retirement. This will prevent tests from running on Windows Server 2012 R2 - Fixes Issue #250.New-CertificateThumbprintand fixed tests for validating FIPS thumbprints inTest-Thumbprintso that it runs on PowerShell Core/7.x.Task list
@johlju - would you mind reviewing when you have time?
This change is