SmbShare: Add support for ScopeName

dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.

MIT License

302 stars 83 forks source link

Pull Request (PR) description

Adds support to create a share in a specific scope into the SmbShare resource, required for example when creating shares in a Windows cluster.

This Pull Request (PR) fixes the following issues

Fixes #284

Task list

[X] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md in the resource folder.
[X] Resource parameter descriptions added/updated in schema.mof and comment-based help.
[X] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[X] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[X] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #291 into dev will increase coverage by <1%. The diff coverage is 100%.

@@ Coverage Diff @@ ## dev #291 +/- ## ==================================== + Coverage 88% 88% +<1% ==================================== Files 14 14 Lines 1478 1480 +2 ==================================== + Hits 1302 1304 +2 Misses 176 176

dsccommunity / ComputerManagementDsc