dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.
https://dsccommunity.org
MIT License
302 stars 83 forks source link

Adds new resource DismFeature #319

Closed johlju closed 4 years ago

johlju commented 4 years ago

Pull Request (PR) description

Deprecates the xDismFeature resource in the module xDismFeature. Suggest doing this instead of maintain a single resource module.

This Pull Request (PR) fixes the following issues

Partly issue https://github.com/PowerShell/DscResources/issues/374

Task list


This change is Reviewable

johlju commented 4 years ago

@PlagueHO let’s wait with this one as it seems this is no longer necessary. If there haven’t been any reported scenarios by this upcoming weekend where this resource is necessary then I close this and just deprecate the xDismFeature repo. If there are scenarios for this in the future I will be keeping the working branch.

PlagueHO commented 4 years ago

@johlju - you might be right. What was the difference between using DISM and *-WindowsFeature? It seems like they cover the same area....

johlju commented 4 years ago

I’m not sure as I never have used DISM to install anything as far as I can remember. I sent a tweet and asked in #DSC channel but haven’t yet seen a scenario where it is needed. Maybe this pre-WindowsFeature (older OS:es that is no longer supported)

PlagueHO commented 4 years ago

Cool. Maybe a resource we could drop. I suspect it was for Windows Server 2008 R2 that didn't have the *-WindowsFeature cmdlets....

johlju commented 4 years ago

Closing this PR. There has not been any reported workloads that need this resource. If a resource for DISM is ever needed then I will keep the working branch, and the code will still exist in the closed PR for reference.