dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.
https://dsccommunity.org
MIT License
300 stars 83 forks source link

ScheduledTask: Fixed execution account missing domain name #356

Closed jensotto closed 3 years ago

jensotto commented 3 years ago

Pull Request (PR) description

Improved PR #351 to include domain accounts.

This Pull Request (PR) fixes the following issues

Fixes #352 Possibly fixes or Improves #144

Task list


This change is Reviewable

PlagueHO commented 3 years ago

Hi @jensotto - thanks for submitting this. It looks like the HQRM tests are failing because an entry hasn't been added to the CHANGELOG.md: See the Update the Changelog section in: https://dsccommunity.org/guidelines/contributing/

jensotto commented 3 years ago

It already contains a message for that change so I didn't add any further comments: Fixed issue with ExecuteAsCredential not returning fully qualified username on newer versions of Windows 10 and Windows Server 2019 - Fixes Issue #352.

PlagueHO commented 3 years ago

Ah, I see. Unfortunately for the tests to pass you'll need to make a correction message.

jensotto commented 3 years ago

Ok, I have mad a small change to the existing entry in changelog.

PlagueHO commented 3 years ago

Hi @jensotto - sorry about the delays in getting to this. Can you resolve the conflicts and I'll review?

jensotto commented 3 years ago

@PlagueHO conflicts resolved