WindowsEventLog: Multiple Updates - Fixes #355, #349, #338, #229

dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.

https://dsccommunity.org

MIT License

300 stars 83 forks source link

WindowsEventLog: Multiple Updates - Fixes #355, #349, #338, #229 #359

Closed cohdjn closed 3 years ago

cohdjn commented 3 years ago

Pull Request (PR) description

Multiple Updates for WindowsEventLog

This Pull Request (PR) fixes the following issues

Fixes #229 Fixes #338 Fixes #349 Fixes #355

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md in resource folder.
[x] Resource parameter descriptions added/updated in schema.mof and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

cohdjn commented 3 years ago

@PlagueHO Any ETA on when you'll be able to do the code review? Anything I can do to help?

PlagueHO commented 3 years ago

Hi @cohdjn - sorry about the delay. I'll be back on this week with reviews. Can you resolve the conflicts on this one?

cohdjn commented 3 years ago

@PlagueHO I never had this problem before so I hope I fixed the conflict correctly! I'm still quite the newbie at all this but I'm learning! :)

PlagueHO commented 3 years ago

/azurepipelines run

azure-pipelines[bot] commented 3 years ago

Azure Pipelines successfully started running 1 pipeline(s).

cohdjn commented 3 years ago

@PlagueHO The integration test bombed outside of this resource. I don't know what I should do at this point?

PlagueHO commented 3 years ago

/AzurePipelines run

azure-pipelines[bot] commented 3 years ago

Azure Pipelines successfully started running 1 pipeline(s).

cohdjn commented 3 years ago

@PlagueHO Have you been able to finish the code review? Anything else you see that should be changed/fixed?

PlagueHO commented 3 years ago

Hi @cohdjn - sorry about the delay. Been snowed under with my day job this week. I'll be onto it this weekend.

cohdjn commented 3 years ago

I think I got everything requested. Just lemme know if there's anything else you see amiss. And please continue to nitpick... the only way I'm going to learn and get better is through this kind of iterative process and I appreciate it!

cohdjn commented 3 years ago

Awesome! Thanks again buddy!!