dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.
https://dsccommunity.org
MIT License
300 stars 83 forks source link

Correct code coverage badge in README.md #370

Closed PlagueHO closed 3 years ago

PlagueHO commented 3 years ago

Pull Request (PR) description

Fixes the Code Coverage badge.

This Pull Request (PR) fixes the following issues

Task list

@johlju - would you mind reviewing for me? Should be a quick one.


This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #370 (3b8f8c1) into main (e645c7e) will increase coverage by 2%. The diff coverage is 86%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #370    +/-   ##
====================================
+ Coverage    88%    90%    +2%     
====================================
  Files        14     17     +3     
  Lines      1469   1682   +213     
====================================
+ Hits       1294   1520   +226     
+ Misses      175    162    -13     
Impacted Files Coverage Δ
...gementDsc.Common/ComputerManagementDsc.Common.psm1 39% <39%> (ø)
...Resources/DSC_ScheduledTask/DSC_ScheduledTask.psm1 86% <78%> (ø)
source/DSCResources/DSC_SmbShare/DSC_SmbShare.psm1 98% <92%> (ø)
...s/DSC_WindowsCapability/DSC_WindowsCapability.psm1 97% <95%> (ø)
...urces/DSC_WindowsEventLog/DSC_WindowsEventLog.psm1 96% <96%> (ø)
source/DSCResources/DSC_Computer/DSC_Computer.psm1 88% <100%> (ø)
...iguration/DSC_IEEnhancedSecurityConfiguration.psm1 100% <100%> (ø)
...s/DSC_OfflineDomainJoin/DSC_OfflineDomainJoin.psm1 89% <100%> (ø)
...Resources/DSC_PendingReboot/DSC_PendingReboot.psm1 98% <100%> (ø)
...urce/DSCResources/DSC_PowerPlan/DSC_PowerPlan.psm1 100% <100%> (ø)
... and 13 more
PlagueHO commented 3 years ago

Thanks @kilasuit - can you review again? I missed a pipeline tweak to update to blog post (https://dsccommunity.org/blog/add-codecov-support-to-repository/).

johlju commented 3 years ago

@PlagueHO We should have changed this one too (to PublishPipelineArtificat):

https://github.com/dsccommunity/ComputerManagementDsc/blob/5648a96b001ae16893ec893c63da7406756353ab/azure-pipelines.yml#L122-L127