Closed nickgw closed 2 years ago
Hi @nickgw - it looks like the pipelines are broken. I'll fix these this weekend so that the CI can run on your build. But in the meantime I'll do a quick review of your PR to get you some suggestions. Thank you for submitting!
Once this PR (https://github.com/dsccommunity/ComputerManagementDsc/pull/384) is merged you should be able to rebase and the pipeline will work.
Merging #381 (18c0c22) into main (f679412) will increase coverage by
0%
. The diff coverage is100%
.
@@ Coverage Diff @@
## main #381 +/- ##
===================================
Coverage 90% 90%
===================================
Files 17 17
Lines 1682 1690 +8
===================================
+ Hits 1520 1528 +8
Misses 162 162
Impacted Files | Coverage Δ | |
---|---|---|
source/DSCResources/DSC_Computer/DSC_Computer.psm1 | 89% <100%> (+<1%) |
:arrow_up: |
Hey @nickgw - your unit tests are failing because this Get-InvalidArgumentException
should be Get-InvalidArgumentRecord
.
I'll have a look at test failures tomorrow night.
Sorry about the delay in looking at this @nickgw - got a bit snowed under. Will try again tomorrow night.
Sorry about the delay in looking at this @nickgw - got a bit snowed under. Will try again tomorrow night.
Thanks, appreciate your time!
Hey @PlagueHO, please let me know when you get a chance to review this again!
Hi @nickgw - sorry about the delay. I'll get onto this this weekend (snowed under with day job). I do notice that the code coverage has dropped ag bit - I think it just needs a unit test that covers these two lines by calling Set with the Options
parameter defined.
Cool - thanks @nickgw - I'll finish review this weekend!
Looks like an intermittent build failure (integration tests on WS2022). So, I've kicked the build again and hopefully will deploy the preview release.
Pull Request (PR) description
Adds Options parameter to Computer resource, as defined in https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.management/add-computer?view=powershell-5.1#parameters
This Pull Request (PR) fixes the following issues
Task list
This change is