dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.
https://dsccommunity.org
MIT License
303 stars 83 forks source link

Fix and Update Pipeline files to latest pattern - Fixes #383 #384

Closed PlagueHO closed 2 years ago

PlagueHO commented 2 years ago

Pull Request (PR) description

This PR updates the pipeline files and github templates to the latest versions. It also fixes the GitVersion task and updates the pipeline agents.

This Pull Request (PR) fixes the following issues

Task list

@johlju - would you mind reviewing when you have a moment?


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #384 (f679412) into main (e645c7e) will increase coverage by 2%. The diff coverage is 86%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #384    +/-   ##
====================================
+ Coverage    88%    90%    +2%     
====================================
  Files        14     17     +3     
  Lines      1469   1682   +213     
====================================
+ Hits       1294   1520   +226     
+ Misses      175    162    -13     
Impacted Files Coverage Δ
...gementDsc.Common/ComputerManagementDsc.Common.psm1 39% <39%> (ø)
...Resources/DSC_ScheduledTask/DSC_ScheduledTask.psm1 86% <78%> (ø)
source/DSCResources/DSC_SmbShare/DSC_SmbShare.psm1 98% <92%> (ø)
...s/DSC_WindowsCapability/DSC_WindowsCapability.psm1 97% <95%> (ø)
...urces/DSC_WindowsEventLog/DSC_WindowsEventLog.psm1 96% <96%> (ø)
source/DSCResources/DSC_Computer/DSC_Computer.psm1 88% <100%> (ø)
...iguration/DSC_IEEnhancedSecurityConfiguration.psm1 100% <100%> (ø)
...s/DSC_OfflineDomainJoin/DSC_OfflineDomainJoin.psm1 89% <100%> (ø)
...Resources/DSC_PendingReboot/DSC_PendingReboot.psm1 98% <100%> (ø)
...urce/DSCResources/DSC_PowerPlan/DSC_PowerPlan.psm1 100% <100%> (ø)
... and 9 more
johlju commented 2 years ago

Not sure why Reviewable "is waiting" for you. 🤔 All good, no more comments. Waiting for the tests to pass then we can merge. 🙂

johlju commented 2 years ago

@PlagueHO it seems this PR need to be rebased...

PlagueHO commented 2 years ago

Thanks @johlju - rebased now. Hopefully tests pass and will then merge. Working on NetworkingDsc now. Will try and get through all the rest this week (finally getting some free time to work on DSC 😁 )

johlju commented 2 years ago

I will review them as soon as I can 🙂 I see the e-mails when you tag me 🙂