Closed nickgw closed 2 years ago
Merging #386 (f59de8f) into main (49b3657) will increase coverage by
0%
. The diff coverage is100%
.
@@ Coverage Diff @@
## main #386 +/- ##
===================================
Coverage 90% 90%
===================================
Files 17 17
Lines 1690 1716 +26
===================================
+ Hits 1528 1554 +26
Misses 162 162
Impacted Files | Coverage Δ | |
---|---|---|
source/DSCResources/DSC_Computer/DSC_Computer.psm1 | 90% <100%> (+1%) |
:arrow_up: |
@nickgw Please change use of backticks in your code to us splatting instead as per https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_splatting?view=powershell-7.2
@nickgw Please change use of backticks in your code to us splatting instead as per https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_splatting?view=powershell-7.2
@kilasuit Should be all set now now
Hi @nickgw - I've merged your other PR (Awesome, thank you), but it's caused some conflicts. Can you resolve?
Hi @nickgw - I've merged your other PR (Awesome, thank you), but it's caused some conflicts. Can you resolve?
Hey @PlagueHO , thanks! I've resolved the merge conflicts.
@PlagueHO I didn't link the issue I was resolving on the other PR correctly. You can close this out: https://github.com/dsccommunity/ComputerManagementDsc/issues/234
Thanks @nickgw - another great job and much appreciated. I'll get onto review tomorrow.
Pull Request (PR) description
When joining a computer to a domain, if a computer object with the same name already exists in the domain it will be deleted.
This Pull Request (PR) fixes the following issues
Task list
This change is![Reviewable](https://reviewable.io/review_button.svg)