Fix mismatch between user and builtinaccount

[nickgw]

Currently ScheduledTask conflates the param BuiltInAccount and *-ScheduledTask cmdlet's user parameter. This fixes that.

Pull Request (PR) description

Currently ScheduledTask conflates the param BuiltInAccount and *-ScheduledTask cmdlet's user parameter. This fixes that.

This Pull Request (PR) fixes the following issues

• Fixes #385

Task list

• [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
• [ ] Resource documentation added/updated in README.md.
• [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
• [ ] Comment-based help added/updated.
• [ ] Localization strings added/updated in all localization files as appropriate.
• [ ] Examples appropriately added/updated.
• [x] Unit tests added/updated. See DSC Community Testing Guidelines.
• [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• [x] New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[codecov[bot]]

Codecov Report

Merging #387 (73dce2d) into main (3aea926) will increase coverage by 0%. The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #387   +/-   ##
===================================
  Coverage    90%    90%           
===================================
  Files        17     17           
  Lines      1716   1726   +10     
===================================
+ Hits       1554   1564   +10     
  Misses      162    162           

Impacted Files	Coverage Δ
...Resources/DSC_ScheduledTask/DSC_ScheduledTask.psm1	87% <100%> (+<1%)	:arrow_up:

[nickgw]

@PlagueHO This should be good to go now, when you get a chance to check it out!

[ShawnHardwick]

Should the MOF schema be updated to match this as well?

https://github.com/dsccommunity/ComputerManagementDsc/blob/main/source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.schema.mof#L16

[nickgw]

Should the MOF schema be updated to match this as well?

https://github.com/dsccommunity/ComputerManagementDsc/blob/main/source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.schema.mof#L16

The inputs don't actually change. The code was comparing the wrong properties.

[PlagueHO]

Hi @nickgw - sorry was tied up on other things. I'll get onto this close to the end of the week. Just need to try and avoid breaking Windows Server 2016 (unfortunately we can't test on it at the moment unless we get something like TK going in Azure).

[nickgw]

Hey @PlagueHO just bumping this (and my related comments in the issue) when you get a chance!

[nickgw]

@PlagueHO Do you mind taking another look at this? I've added another test.

[nickgw]

@PlagueHO do you mind taking another look at this? I'd love to close this off my list.

[PlagueHO]

Cool! Thanks @nickgw - I'll review tonight.

[nickgw]

@PlagueHO I think I hit all your comments!