dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.
https://dsccommunity.org
MIT License
303 stars 83 forks source link

Suggest making class-based resources re-use module DscResource.Base #404

Closed johlju closed 1 year ago

johlju commented 1 year ago

The class ResourceBase and Reason, plus enum Ensure have been moved to the module DscResource.Base so that we don't need to duplicate code between DSC resource modules.

Suggest that the class-based resources in thi module re-use that module by modifying RequiredModules.ps1 and build.yaml to use it the same way we re-use commands from module DscResource.Common.

This move has already been done for SqlServerDsc, and I have tested so that the resources from different modules do not clash when re-using the module DscResource.Base. I documented it here: https://github.com/dsccommunity/SqlServerDsc/issues/1790