dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.
https://dsccommunity.org
MIT License
309 stars 82 forks source link

ComputerManagementDsc: Add missing unit tests #406

Closed johlju closed 1 year ago

johlju commented 1 year ago

Pull Request (PR) description

The PR #402 will add unit tests for private function ConvertTo-Reason. The unit tests was converted from Pester 5 with as few changes as possible.

NOTE: This PR becomes obsolete if PR #405 is merged, merging that PR will close this PR.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #406 (08a09f6) into main (bf1ad27) will increase coverage by 0%. The diff coverage is n/a.

:exclamation: Current head 08a09f6 differs from pull request most recent head 5ee3eb4. Consider uploading reports for the commit 5ee3eb4 to get more accurate results

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #406   +/-   ##
===================================
  Coverage    89%    89%           
===================================
  Files        18     18           
  Lines      1940   1940           
===================================
+ Hits       1730   1731    +1     
+ Misses      210    209    -1     
Impacted Files Coverage Δ
source/ComputerManagementDsc.psm1 78% <0%> (+<1%) :arrow_up:
PlagueHO commented 1 year ago

Hi @johlju - this PR auto closed when I merged #405 - is this PR no longer required as the files that are bieng unit tested aren't here any more...

johlju commented 1 year ago

Correct. Sine the class-based resource now used the base class from the dependent module all these functions are no longer needed as they are part of the dependent module.