dsccommunity / ComputerManagementDsc

DSC resources for for configuration of a Windows computer. These DSC resources allow you to perform computer management tasks, such as renaming the computer, joining a domain and scheduling tasks as well as configuring items such as virtual memory, event logs, time zones and power settings.
https://dsccommunity.org
MIT License
303 stars 83 forks source link

Update pipeline files to latest version - Fixes #427 #428

Closed PlagueHO closed 4 months ago

PlagueHO commented 4 months ago

Pull Request (PR) description

This PR updates the pipeline and supporting files to the latest DSC Community pattern. It also updates the HQRM VM images to run on windows-latest.

This Pull Request (PR) fixes the following issues

Task list

Remaining N/A


This change is Reviewable

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90%. Comparing base (196d491) to head (52669cd). Report is 3 commits behind head on main.

:exclamation: Current head 52669cd differs from pull request most recent head 400748b

Please upload reports for the commit 400748b to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/ComputerManagementDsc/pull/428/graphs/tree.svg?width=650&height=150&src=pr&token=n7Sx5K7YGT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/ComputerManagementDsc/pull/428?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #428 +/- ## =================================== Coverage 90% 90% =================================== Files 18 18 Lines 1801 1803 +2 =================================== + Hits 1631 1633 +2 Misses 170 170 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/dsccommunity/ComputerManagementDsc/pull/428/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)
johlju commented 4 months ago

The pipeline in the change has enable PSResourceGet, and the compatibility module is not 100% so guessing thats why the integration tests fails. Maybe disable PowerShellGet compatibility module in config Resolve-Dependency.psd1 and then maybe it is possible to force to load old PowerShellGet for the integration tests?

Or just disable PSResourceGet and keep using PowerShellGet for now?

johlju commented 4 months ago

Also, FYI: https://github.com/dsccommunity/ActiveDirectoryCSDsc/pull/144#issuecomment-2143328779

johlju commented 4 months ago

Also, FYI: dsccommunity/ActiveDirectoryCSDsc#144 (comment)

This has been fixed in a new release.

PlagueHO commented 4 months ago

Thanks @johlju - looking at this now and have turned off the PSResourceGet usage.

PlagueHO commented 4 months ago

Should be good to review now @johlju 😀